openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Hyundai: enforce ACC main state with controls allowed

Open sunnyhaibin opened this issue 3 years ago • 1 comments

Enforce ACC main state with stock/openpilot longitudinal control in openpilot and panda safety.

Stock ACC: SCC11|MainMode_ACC

openpilot ACC: EMS16|CRUISE_LAMP_M

  • Available on all currently supported openpilot longitudinal HKG cars
  • Sync with ACC MAIN button press
  • Will be copied and sent with SCC11|MainMode_ACC to the car when ACC MAIN is pressed

In conjunction with:

  • https://github.com/commaai/panda/pull/1054

sunnyhaibin avatar Aug 31 '22 19:08 sunnyhaibin

Upon testing on some older models, the signal does not do anything when the CRUISE MAIN button is pressed. Need to investigate and see if there is another common signal to use for those cars.

sunnyhaibin avatar Oct 03 '22 01:10 sunnyhaibin

Is there a signal in TCS that describes this?

sshane avatar Aug 17 '23 03:08 sshane

@sunnyhaibin if we don't expect this to be mergable soon, can we close until it is?

adeebshihadeh avatar Aug 24 '23 20:08 adeebshihadeh

@sunnyhaibin if we don't expect this to be mergable soon, can we close until it is?

Yes that works for me. I'll open a new PR when it's ready.

sunnyhaibin avatar Aug 24 '23 20:08 sunnyhaibin