openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

OP late braking for lead (planner lag and actuator lag)

Open iamjackg opened this issue 3 years ago • 5 comments

Describe the bug

Yesterday I had my first instance of OP not braking in time for a lead car and triggering the AEB warning: I felt like I had to slam on the brakes to stop safely. I'm on stock 0.8.15 on a Comma 3 with a 2018 RAV4 Hybrid + SDSU.

Provide a route where the issue occurs

b4069565beef1091|2022-07-26--17-20-36--5

openpilot version

0.8.15

Additional info

No response

iamjackg avatar Jul 27 '22 14:07 iamjackg

The lead car braked pretty hard (-5 m/s^2), but looks like the car was slow in responding to the ACC command. Probably a duplicate of https://github.com/commaai/openpilot/issues/2731.

@sshane any ideas why it didn't respond?

image

pd0wm avatar Jul 27 '22 14:07 pd0wm

Interesting, thanks for the plot :) I was trying to get plotjuggler going, but I'm still on Ubuntu 18.04, so no dice. Note that my RAV4 should be on TSS-P, not TSS2, although I guess the Hybrid model is a bit weird in that regard?

iamjackg avatar Jul 27 '22 14:07 iamjackg

While the car did respond late to the requests late (and I'm not totally sure why), I also see the planner was pretty delayed to request enough braking. For example, while the lead is at -2.3 m/s/s we're only requesting -0.8 m/s/s

Screenshot from 2022-07-27 11-13-31

sshane avatar Jul 27 '22 18:07 sshane

Is there anything else I can do to help diagnose this? Or are you going to put this item on your list and work on it internally?

iamjackg avatar Jul 29 '22 19:07 iamjackg

Adding 2 similar issues here https://github.com/commaai/openpilot/issues/20970 and https://github.com/commaai/openpilot/issues/25194

haraschax avatar Aug 06 '22 00:08 haraschax

Master has improved Toyota longitudinal now.

adeebshihadeh avatar Jan 12 '25 23:01 adeebshihadeh