openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Genesis GV70 2022 port

Open zunichky opened this issue 3 years ago • 5 comments

GV70 Car port

Checklist

  • [x] added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • [x] test route added to routes.py
  • [x] route with openpilot: ca4de5b12321bd98|2022-08-22--20-23-34
  • [x] route with stock system: ca4de5b12321bd98|2022-08-22--20-20-29

Todos:

  • Create GV70 vehicle (remove EV6 dependency)
    • DBC file
    • Carstate
    • Interface
    • HDA2can
    • Values
  • Add acc/brake/gear
  • Panda Safety Cleanup
  • Get fingerprinting working
  • Tune
  • Genericize "HDA2" in the code
    • This might be better suited in another PR
  • Docs
  • Test drives

zunichky avatar Jul 12 '22 21:07 zunichky

Looks like you're on the right track here. Let me know if you have any questions!

adeebshihadeh avatar Jul 12 '22 21:07 adeebshihadeh

@sshane @adeebshihadeh I'm currently stuck on the two below items if you guys could be of any assistance, or point me to correct docs/people to help.

Getting accelerator_pedal command: https://discord.com/channels/469524606043160576/524611978208215070/999060819180527801

Tuning: https://discord.com/channels/469524606043160576/574796986822295569/998328655770030171

Thanks for the help thus far! I'm slowly getting there :)

zunichky avatar Jul 20 '22 02:07 zunichky

@adeebshihadeh Finally getting this close to PR ready. Biggest thing now is my panda safety. https://github.com/commaai/panda/pull/1023 I have it working, but I need some help on making it generic across platforms, or possibly having the gv70 have it's own safety file.

zunichky avatar Aug 11 '22 20:08 zunichky

@adeebshihadeh Finally getting this close to PR ready. Biggest thing now is my panda safety. commaai/panda#1023 I have it working, but I need some help on making it generic across platforms, or possibly having the gv70 have it's own safety file.

I merged the HDA1 Tucson today, which should hopefully make it generic enough to cover the GV70. Can you rebase on master? Also, a test route would be helpful.

adeebshihadeh avatar Aug 20 '22 06:08 adeebshihadeh

@adeebshihadeh Finally getting this close to PR ready. Biggest thing now is my panda safety. commaai/panda#1023 I have it working, but I need some help on making it generic across platforms, or possibly having the gv70 have it's own safety file.

I merged the HDA1 Tucson today, which should hopefully make it generic enough to cover the GV70. Can you rebase on master? Also, a test route would be helpful.

Route is uploaded, I'm getting the following error though.. I uploaded the logs and made public on useradmin. Is it possibly because there is no fingerprint?

Exception: Route: 'ca4de5b12321bd98|2022-08-22--20-23-34' with segments: (2, 1, 0) not found or no CAN msgs found. Is it uploaded?

zunichky avatar Aug 23 '22 13:08 zunichky

@sshane @adeebshihadeh I know this one is a little more complex than the rest of the can-fd ports have been such far, but anything else I can do to get this merged in? I have another person who got it up and running, and a couple others who have messaged me. I know that's not a ton of people, but 2 fold from a few weeks ago :)

zunichky avatar Sep 28 '22 23:09 zunichky

@sshane @adeebshihadeh I know this one is a little more complex than the rest of the can-fd ports have been such far, but anything else I can do to get this merged in? I have another person who got it up and running, and a couple others who have messaged me. I know that's not a ton of people, but 2 fold from a few weeks ago :)

I did a bunch of cleanup for the CAN-FD Hyundai's today to make everything a bit more generic. Can you rebase on master and cleanup your branch?

adeebshihadeh avatar Oct 13 '22 05:10 adeebshihadeh

Moving to #26068

zunichky avatar Oct 13 '22 15:10 zunichky