openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Support asymmetric minimum steering speeds

Open sshane opened this issue 2 years ago • 3 comments

sshane avatar Jun 29 '22 00:06 sshane

On a similar note, some cars (gm) have different initial vs subsequent minimum engage speeds. The 2017 volt must engage over 18mph the first time but can then engage from 1. Meanwhile the 2018 volt can engage from 1 initially.

twilsonco avatar Jun 29 '22 01:06 twilsonco

Does this cause problems in any cases? Or does the car tell you to engage at a minimum speed the first attempt? This PR is to fix some faults and remove duplicated logic across some makes for asymmetrical steering speeds

sshane avatar Jun 29 '22 02:06 sshane

2017 volt drivers can either set the minimum speed to 0 and ACC will fault if they initially engage too low, or they leave it set at 18mph to avoid the potential for faults and take the convenience hit. Other gm cars might be in a similar boat but not sure. On Jun 28, 2022, 8:00 PM -0600, Shane Smiskol @.***>, wrote:

Does this cause problems in any cases? Or does the car tell you to engage at a minimum speed the first attempt? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

twilsonco avatar Oct 11 '22 09:10 twilsonco

Not sure of the state of this any more. We should support all the needed behavior per car-port (we don't yet), then make it common once we understand the full space of possible behaviors.

sshane avatar Jul 31 '23 20:07 sshane