openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Published 20 hours ago • verified publisher icon commaai

Laikad use subsock

Open gijskoning opened this issue 3 years ago • 5 comments
trafficstars

gijskoning avatar Jun 17 '22 11:06 gijskoning

Let's add to process replay first with the submaster. Subsockets need some special care in process replay.

pd0wm avatar Jun 17 '22 11:06 pd0wm

@HaraldSchafer want to keep this open?

adeebshihadeh avatar Aug 11 '22 03:08 adeebshihadeh

Don't understand this change, so closing. @adeebshihadeh Feel free to merge if you want to.

haraschax avatar Aug 15 '22 17:08 haraschax

Using a submaster can drop messages if the main loop takes too long to process (since all sockets are conflated). Specifically dropping an ephemeris message would be annoying. Not sure if this is a problem in practice.

pd0wm avatar Aug 15 '22 17:08 pd0wm

Yeah, we shouldn't really not do this because it's not convenient to test in process replay. I'll reopen and handle making it work in process replay.

adeebshihadeh avatar Aug 15 '22 18:08 adeebshihadeh