openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Pipenv -> poetry

Open haraschax opened this issue 3 years ago • 6 comments
trafficstars

  • removes pipenv from openpilot
  • add poetry, dependencies defined in pyproject.toml
    • poetry install --no-root so that "openpilot" isn't installed as a package itself...
  • add xx packages to an optional dependency group
    • if xx dir is present, installs packages to system (POETRY_VIRTUALENVS_CREATE=false) and --with xx

haraschax avatar Jun 14 '22 18:06 haraschax

Poetry 1.2 (with package groups) was just released: https://python-poetry.org/blog/announcing-poetry-1.2.0/

pd0wm avatar Sep 11 '22 15:09 pd0wm

Cool! might try to revive this.

haraschax avatar Sep 14 '22 08:09 haraschax

@incognitojam can you finish this up? goal is to get rid of xx/blob/master/pipenv-merge.sh in a clean way. if we can't do that, then let's just close this

adeebshihadeh avatar Oct 12 '22 21:10 adeebshihadeh

@adeebshihadeh we could export the dependencies from the pyproject.toml to generate the xx Pipfile..

or I'm thinking we add openpilot as a dependency of xx? then running pipenv install in xx would install the openpilot deps

incognitojam avatar Oct 13 '22 21:10 incognitojam

I've added semver version constraints to all of the * packages, using the version from the old Pipfile.lock, so they shouldn't have breaking changes.. Also pinned the Python version to ~3.8.

incognitojam avatar Oct 20 '22 18:10 incognitojam

if CI passes this should be ready to review!

incognitojam avatar Oct 21 '22 01:10 incognitojam