opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard

Enable 100% branch coverage check

Open adeebshihadeh opened this issue 5 months ago • 5 comments

Your goal is to enable the branch coverage check and carefully fix all the violations.

For each violation:

  1. can we remove this branch?
  2. can we rewrite this branch?
  3. add test coverage

Our test coverage should be fairly complete, so this should mostly be removing and rewriting.

Here's where we're at now: Image

adeebshihadeh avatar Jul 25 '25 16:07 adeebshihadeh

@adeebshihadeh I would like to work on this? Can I get assigned?

varshith257 avatar Jul 26 '25 01:07 varshith257

@adeebshihadeh I would like to work on this? Can I get assigned?

You can just do things!

adeebshihadeh avatar Jul 26 '25 01:07 adeebshihadeh

I just tried out some improvements. I think it will take some time to raise coverage of each module.

shreyanshjain7174 avatar Jul 26 '25 11:07 shreyanshjain7174

Locked to @ssysm

adeebshihadeh avatar Jul 29 '25 16:07 adeebshihadeh

hey @adeebshihadeh is this issue open to work on now?

PhantomInTheWire avatar Sep 07 '25 03:09 PhantomInTheWire