opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard

GM: FPv3 based on VIN

Open garrettpall opened this issue 11 months ago • 7 comments

garrettpall avatar Jan 12 '25 16:01 garrettpall

Have we evaluated if we need the VIN to match and not the camera FW versions we now gather?

sshane avatar Jan 13 '25 02:01 sshane

Have we evaluated if we need the VIN to match and not the camera FW versions we now gather?

Currently there is no way for me to look at the firmware’s collected as the public database hasn’t been updated since after the query has been implemented.

I put this together based off a comment from Jason: https://discord.com/channels/469524606043160576/1282121586002104402/1327798185460240457

I like the idea of fingerprinting off the vin because it is something that can be decoded and has a meaning behind it instead of firmware versions being in a lookup database.

Once the public dataset is updated, I can look into firmware versions.

garrettpall avatar Jan 13 '25 09:01 garrettpall

Current master/release does not recognize a 2022 Trailblazer, this PR picks up and fingerprints properly as a Trailblazer correctly

Here is a route for a 2022 Trailblazer working: f97ecb0c37e04cc2/00000000--7ce0807334/0

morrislee avatar Jan 18 '25 23:01 morrislee

Do we need more validation for this to be merged? if so, what else is needed?

morrislee avatar Apr 03 '25 00:04 morrislee

Do we need more validation for this to be merged? if so, what else is needed?

I need the comma public segments to get updated to make sure this works for all GMs.

garrettpall avatar Apr 03 '25 00:04 garrettpall

This PR has had no activity for 60 days. It will be automatically closed in 7 days if there is no activity.

github-actions[bot] avatar Sep 21 '25 02:09 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Sep 29 '25 02:09 github-actions[bot]