opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard
verified publisher icon commaai

Hyundai: Disable longitudinal for HDA2 without ADAS Driving ECU

Open sunnyhaibin opened this issue 1 year ago • 2 comments

Description

For some HDA2 cars, the ECU that broadcasts SCC messages is still undetermined (historically should be the ADAS Driving ECU), therefore there is no known method to enable longitudinal control on these yet. Disable longitudinal control for the time being for applicable cars.

Offline Validation

  • [x] pytest opendbc
  • [x] pytest selfdrive/car/tests
  • [x] selfdrive/test/process_replay/test_processes.py

Affects

  • https://github.com/commaai/opendbc/pull/1132
  • https://github.com/commaai/opendbc/pull/1133

sunnyhaibin avatar Sep 27 '24 05:09 sunnyhaibin

Depends on, and will need a rebase after #1294.

jyoung8607 avatar Sep 27 '24 17:09 jyoung8607

Offline validations passed.

sunnyhaibin avatar Sep 27 '24 20:09 sunnyhaibin

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Nov 13 '24 02:11 github-actions[bot]

HDA2 kinda means "has ADAS ECU", or at least that's what I meant at the time. It's probably time we rethought some of these names and classes.

adeebshihadeh avatar Nov 28 '24 21:11 adeebshihadeh