opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard

Hyundai CAN Longitudinal: Enable for Camera SCC cars

Open sunnyhaibin opened this issue 1 year ago • 3 comments

Description

openpilot longitudinal control support for CAN-based HKG cars that have the following messages send from the car on bus 2:

  • SCC11
  • SCC12
  • SCC13
  • SCC14
  • FCA11
  • FCA12

Currently with 2022 Hyundai Kona EV, without radar disable. As the messages send from the car on bus 2, we block the messages and send our own longitudinal commands to bus 0.

FCA11 and FCA12 do stock FCW and AEB, and are forwarded from the LKAS camera to the car.

Supersedes

  • https://github.com/commaai/openpilot/pull/26090/files

Requires

  • https://github.com/commaai/panda/pull/1107

sunnyhaibin avatar Sep 25 '24 04:09 sunnyhaibin

Route with stock FCW active: d3a039910163c67a/000000cb--b5898024e5

image

sunnyhaibin avatar Sep 27 '24 03:09 sunnyhaibin

Another working test route: ecb854b94fdfa4d5/00000001--70960afd85

sunnyhaibin avatar Sep 27 '24 18:09 sunnyhaibin

Test route with stock AEB actively braking for the car! d3a039910163c67a/000000d1--754d5d6111 image

sunnyhaibin avatar Sep 28 '24 01:09 sunnyhaibin

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Nov 14 '24 02:11 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Nov 21 '24 02:11 github-actions[bot]

I resolved the conflict, but can't push to the branch because it's from the sunnypilot org. Can you add write access for me, shane, and jason to the repo you're gonna make PRs from?

adeebshihadeh avatar Nov 21 '24 18:11 adeebshihadeh

I resolved the conflict, but can't push to the branch because it's from the sunnypilot org. Can you add write access for me, shane, and jason to the repo you're gonna make PRs from?

Invitation sent!

sunnyhaibin avatar Nov 21 '24 20:11 sunnyhaibin

Fails test_models in openpilot: https://github.com/commaai/openpilot/actions/runs/11966321616/job/33361765473

sshane avatar Nov 22 '24 04:11 sshane

@adeebshihadeh @sshane Reopened https://github.com/commaai/opendbc/pull/1563 with fix.

sunnyhaibin avatar Dec 07 '24 15:12 sunnyhaibin