opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard
verified publisher icon commaai

Honda Odyssey 2020: longitudinal API not fully understood

Open haraschax opened this issue 4 years ago • 3 comments

We use PCM_GAS value to set max acceleration for Honda NIDECs, this does not work for 2020 Odyssey. We need to understand the API for this NIDEC and cars like it.

haraschax avatar Sep 06 '21 21:09 haraschax

Hi all, would love to work on this issue. Just needing help in locating the API that you are mentioning. Thanks in Advance!

BBBmau avatar Sep 09 '21 16:09 BBBmau

We use PCM_GAS value to set max acceleration for Honda NIDECs, this does not work for 2020 Odyssey.

~Do you mean PCM_ACCEL?~

(I assume that merged PR commaai/openpilot#22156 was the workaround for this issue.)

belm0 avatar Sep 24 '21 10:09 belm0

I see, it's PCM_GAS

https://github.com/commaai/openpilot/blob/3ccf712ac99ce8ef393d87ddd7241d1d823dd5a6/selfdrive/car/honda/hondacan.py#L122

this comment threw me off, referring to it as "PCM_ACCEL":

https://github.com/commaai/openpilot/blob/3ccf712ac99ce8ef393d87ddd7241d1d823dd5a6/selfdrive/car/honda/carcontroller.py#L189-L190

belm0 avatar Sep 24 '21 12:09 belm0

The fix similarly corrected my 2020 MDX. Why is this bug not set to closed?

mvl-boston avatar Mar 26 '25 21:03 mvl-boston