opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard

Toyota Corolla Hybrid: Extremely slow acceleration and early braking when using 'Aggressive' mode

Open TKassis opened this issue 2 years ago • 5 comments

Describe the bug

Aggressive mode seems to be opposite of what it intends to do. Acceleration when the lead starts moving is extremely slow and the car tends to brake way too early when stopping for a lead. I've always had these issues with OpenPilot, but though 'Aggressive' mode would help address them, but for some reason it makes them substantially worse.

Which car does this affect?

Toyota Corolla Hybrid 2021

Provide a route where the issue occurs

ecebb0b63434e2f2|2023-06-23--12-14-31--6

openpilot version

0.9.4

Additional info

No response

TKassis avatar Jun 24 '23 19:06 TKassis

Can you get a new route with rlogs? The ones for this route are gone already. It looks like (from the rough qlogs) when coming to a stop, it didn't overshoot braking too badly, and was generally following the plan well, so it doesn't look like a control issue there: @haraschax is this late braking expected? It looks like he might have enabled kind of late.

image

But it did lag when resuming later in the segment, I'm looking into how the PCM transforms our acceleration request when I have free time here and there, hoping to fix this kind of stuff soon.

sshane avatar Jun 26 '23 21:06 sshane

The brake response doesn't look great, but I don't think it's unexpected.

haraschax avatar Jun 27 '23 03:06 haraschax

@TKassis do you have any more recent examples?

sshane avatar Aug 08 '23 03:08 sshane

Not right now. My Comma is on it's way back to me after some hardware repairs, but I'll upload some more drive when I get it later this week.

TKassis avatar Aug 08 '23 13:08 TKassis

Here are a few more segments with extremely slow acceleration (some in aggressive and some in standard although these settings don't seem to affect my acceleration):

b434e73e06865d48|2023-08-23--17-53-56--18

b434e73e06865d48|2023-08-23--17-53-56--23

b434e73e06865d48|2023-08-23--17-53-56--23

b434e73e06865d48|2023-08-23--17-53-56--31

TKassis avatar Aug 25 '23 01:08 TKassis

Since this issue is mostly about slow acceleration with the more recent reports, going to close as completed by https://github.com/commaai/opendbc/pull/1464!

Please make a new issue for the laggy braking if you have any bad examples recently.

sshane avatar Nov 12 '24 23:11 sshane