HKG: Car Port for Kia Sportage Plug-in Hybrid 2023

[sunnyhaibin]

Checklist

• [x] added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
• [x] test route added to routes.py
• [x] route with stock system: 428412ad82894ba3|2023-10-27--15-44-21
• [x] route with openpilot: 428412ad82894ba3|2023-12-09--17-01-47
• [x] harness Type: Hyundai N
• [x] architecture: CAN-FD

Link to all physical parts during installation

• comma 3X
• car harness kit
  • Hyundai N

Thanks to the community 2022 Kia Sportage Plug-in Hybrid owner dhimmels.

Requires

• https://github.com/commaai/panda/pull/2038

Supersedes https://github.com/commaai/openpilot/pull/30575

[github-actions[bot]]

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

• Convert your PR to a draft unless it's ready to review
• Read the contributing docs
• Before marking as "ready for review", ensure:
  • the goal is clearly stated in the description
  • all the tests are passing
  • include a route or your device' dongle ID if relevant

[jyoung8607]

According to the history this vehicle does have much higher lateral control authority, and it also has the known issues with "grasp wheel" and "take a break" HUD alerts.

Those need to be sorted out before the car can ship as fully supported, and since it's a combined platform with the existing Sportage, there's not an easy option to merge as dashcam either. I think all these issues are fixable, but they're blockers for this PR.

• [ ] Need to handle drastic change in lateral control response
• [ ] Need to handle spurious HUD alerts

[sunnyhaibin]

Using fwdCamera for now to distinguish between PHEV and other variants for the second alternative limits.

[xtian]

@jyoung8607 What's remaining to be done here?

[xtian]

@jyoung8607 We’re approaching two years since the first PR for this car model was opened. What is blocking this from acceptance?

[scourge76]

Any News here? What needs to be done for a Full Release?

[xtian]

@scourge76 Nothing, as I’ve been driving using this branch for a year without issue, but Comma has communicated that they don’t want to add additional car ports for the foreseeable future

[dhimmel]

Comma has communicated that they don’t want to add additional car ports for the foreseeable future

That's a shame since this integration effort predates this alleged change in policy, and highly similar cars are officially supported such as the 2024 Hyundai Tucson Plug-in Hybrid and 2023 Kia Sportage Hybrid.

Looking at other repo activity, car ports continue to get reviewed and merged, so I think it's really just a matter of us getting this PR to a mergeable state and then getting a maintainer's attention.