opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard

HKG: Car Port for Genesis G70 2024

Open sunnyhaibin opened this issue 1 year ago • 5 comments

Checklist

  • [x] added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • [x] test route added to routes.py
  • [x] route with openpilot: a6310918f9699ef5/2024-02-28--14-55-10
  • [x] route with stock system: a6310918f9699ef5/2024-02-27--20-17-09
  • [x] car harness used (if comma doesn't sell it, put N/A): Harness F
  • [x] Suppress "grasp not detected" when openpilot steering and stock system's longitudinal are engaged on highways, where HDA usually is available

Thanks to the community 2024 Genesis G70 owner mayday4968 (Discord).

Requires

  • https://github.com/commaai/panda/pull/2045

Superseded https://github.com/commaai/openpilot/pull/31625

sunnyhaibin avatar Aug 20 '24 14:08 sunnyhaibin

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Aug 20 '24 14:08 github-actions[bot]

Awaiting new test route from user

sunnyhaibin avatar Sep 27 '24 18:09 sunnyhaibin

If the "grasp not detected" mitigation is compatible with all HKG with CAMERA_SCC, let's bring that out into a separate PR, and rename the safety PR to reflect what it's doing. That way we can understand it in isolation, and this will become a regular model port.

jyoung8607 avatar Oct 03 '24 22:10 jyoung8607

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Nov 17 '24 02:11 github-actions[bot]

This PR is pending so long time. I have a 2025 GV70 but haven’t been able to use OP so far. I hope PR will continue to be supported so I can use it soon.

chanhojung avatar Feb 07 '25 03:02 chanhojung