opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard

HKG: Car Port for Genesis GV70 2022-23 (HDA2)

Open sunnyhaibin opened this issue 1 year ago • 3 comments

Checklist

  • [x] added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • [x] test route added to routes.py
  • [x] route with openpilot:
    • f1b6af6fdf6c0a78: f1b6af6fdf6c0a78/00000004--5a6db3a9bd
    • 1159e79fa5ec2cb0: 1159e79fa5ec2cb0/0000000a--0dd85e8bd2
  • [x] route with stock system: afe09b9f5d3f3548/00000005--fe8cd35e57
  • [x] car harness used (if comma doesn't sell it, put N/A): N/A (See below)
    • 2.5T, HDA2
      • Harness P
    • 3.5T, HDA2
      • Harness S: https://github.com/commaai/opendbc/issues/1297

Thanks to the community 2022 Genesis GV70 3.5T owners taylababygirl (Discord) and animatronichobbes.

Offline Validation

  • [x] pytest opendbc
  • [ ] pytest selfdrive/car/tests
  • [ ] selfdrive/test/process_replay/test_processes.py

Superseded https://github.com/commaai/openpilot/pull/31704

sunnyhaibin avatar Aug 20 '24 14:08 sunnyhaibin

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Aug 20 '24 14:08 github-actions[bot]

Genesis GV70 2022, 2.5T, HDA2: 1159e79fa5ec2cb0/00000001--b77cb31c46

sunnyhaibin avatar Sep 26 '24 20:09 sunnyhaibin

@jyoung8607 Test route has rlogs uploaded and preserved.

sunnyhaibin avatar Sep 28 '24 01:09 sunnyhaibin

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Nov 17 '24 02:11 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Nov 23 '24 02:11 github-actions[bot]

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Dec 04 '24 02:12 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Dec 12 '24 02:12 github-actions[bot]

This PR has had no activity for 60 days. It will be automatically closed in 7 days if there is no activity.

github-actions[bot] avatar Feb 12 '25 02:02 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Feb 19 '25 02:02 github-actions[bot]

@sunnyhaibin This looks to be one of the cars we just spoke about, that have really atrocious controls response. I don't think I feel good about shipping these to release, the driving experience is clearly unpleasant.

Let's spend some time figuring out why these cars behave so oddly. Can we get a stock ADAS route to compare?

image

jyoung8607 avatar Feb 24 '25 06:02 jyoung8607

I'm looking to pick up from this PR + #33335 to get my 2024 GV70 3.5T going, are there any specific needs/reqs for the requested route with the stock LKAS enabled @jyoung8607? Here's a short one 3ff91a450f6b01f0/0000000e--f7d9d49361/0 albeit a rainy evening wasn't its' best showing.

dbuck avatar May 22 '25 00:05 dbuck