opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard

Hyundai: Add FW Versions for Staria 2024

Open sunnyhaibin opened this issue 1 year ago • 2 comments

Add firmware versions for the Hyundai Staria 2024. Expand supported model-year range up to 2024.

Route 6e25dbed0748e26a/00000001--50344558ed

Thanks to the community 2024 Hyundai Staria owner ciapek4473 (Discord).

Supersedes https://github.com/commaai/openpilot/pull/32832

sunnyhaibin avatar Aug 20 '24 13:08 sunnyhaibin

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Aug 20 '24 13:08 github-actions[bot]

The PR looks fine, but have requested an uploaded test drive with openpilot engaged, just to make sure lateral control performance is what we expect for this model.

jyoung8607 avatar Sep 25 '24 00:09 jyoung8607

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Nov 18 '24 02:11 github-actions[bot]

Reached out to user for new route.

sunnyhaibin avatar Feb 23 '25 05:02 sunnyhaibin

Replying to self...

The PR looks fine, but have requested an uploaded test drive with openpilot engaged, just to make sure lateral control performance is what we expect for this model.

Looked at a recent set of qlogs from this same Staria. It's got the jank. 😞

@sunnyhaibin Feel free to re-open this PR when we have a general solve for this class of steering issues.

6e25dbed0748e26a/0000026f--97850a0793

image

jyoung8607 avatar Mar 12 '25 01:03 jyoung8607