cabana icon indicating copy to clipboard operation
cabana copied to clipboard

Cabana loses messages in dbc file

Open edude03 opened this issue 7 years ago • 4 comments

Not sure why this happens but sometimes when I save a DBC file, then load it again later, I notice messages that were previously defined aren't there anymore. Not sure how to reproduce it, but here is an example

https://github.com/edude03/opendbc/commit/315d0c02ad75b57d2af3a7be05a3c173a35a5143#diff-abcd5cc6c032c059a532d9896668e1b6L85

edude03 avatar Jan 15 '18 16:01 edude03

help wanted label is for anyone who can find a good reproduction case (step by step would be useful).

@edude03 When you say the messages "aren't there anymore" can you be a bit more specific? Do they revert to untitled, not show up in the messages list at all, etc.

ChristopherBiscardi avatar Jan 16 '18 19:01 ChristopherBiscardi

I think I’ve experienced this too. Seems like cabana just forces its own history instead of dealing with merge conflicts. Maybe there’s also a problem with conflicting localstorage versions of the dbc if multiple tabs are open?

adeebshihadeh avatar Feb 01 '18 20:02 adeebshihadeh

commaai/cabana#100 spaces and names that are too long will not be saved, hence the disappearing labels

bugsy924 avatar Mar 18 '18 04:03 bugsy924

dashes are a problem too

stefan-menin avatar Mar 19 '18 04:03 stefan-menin