Colton Hurst

Results 25 comments of Colton Hurst

> I think we can safely update the `version` endpoint to also use the new AssemblyHelpers, and make a note for QA to test this. @Hinton I updated the references...

> Good eye! It wouldn't be a bad idea to do so, however, is it overkill? I'm not super versed on testing so I couldn't say - but to me,...

Thanks @kimdre for opening this as well as your [PR](https://github.com/bitwarden/sm-action/pull/102). For anyone following this thread, for consistency, an internal tracking ticket has been created: [SM-1220](https://bitwarden.atlassian.net/browse/SM-1220) [SM-1220]: https://bitwarden.atlassian.net/browse/SM-1220?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Thanks @kimdre for your PR :) Looks like we don't have CLAassistant and the bitwarden-bot (to create internal tickets) running for sm-action yet. I've created the internal ticket [SM-1220](https://bitwarden.atlassian.net/browse/SM-1220) to...

> @coltonhurst Hi, are there any plans to merge this PR in the near future? Hey @kimdre, one of our team members will be looking at this soon! Thanks for...

Not a bad location, but I agree we should think about where we want this. (If we do keep it in the `bws` crate I think it should definitely be...

> Approved, but would like to know other's feedback @coltonhurst on whether uninstalling should also remove `.bws` config directory - i am personally fine with it. Yeah I think we...

Closing in favor of new `sm/sm-1096` PR: https://github.com/bitwarden/sdk/pull/895

> Most of the time the validation of create and update are identical. Do we want to tie those implementations together somehow? I think that's a good idea. Due to...

> @coltonhurst This looks like it's covered by the now merged #810, so we can probably close this right? yep! Closing it, thank you :)