collerek comments

Results 101 comments of


                                            collerek

Issue with clause column extraction

You have only 3 with queries (so kind of sub queries), where is the final query used?

Issue with clause column extraction

OK, so the current output is: `['VALUE', 'EMP.AS_DT', 'ALS.VALUE', 'APS.QTY', 'ALS.PD_TYPE', 'APS.PD_TYPE', '*', 'PD_TYPE']`. That's because the `with` queries are not considered as sub-queries so as of now they are...

CTE column names

For now parser does not infer tables so you need to prepend colum with source. Change `select pid from cte` to `select cte.pid from cte` and it will work as...

Allow nesting ormar models in pydantic models

You have get_pydantic method for that https://collerek.github.io/ormar/models/methods/#get_pydantic

Internally inconsistent documentation of `get` and `first` w.r.t. behaviour on multiple resulting rows

Well it behaves differently depending if you pass any filters or not. When called empty (`get() or `first()`) it returns last/first row ordered by pk. If you set a filter...

Create mypy plugin to handle common pitfalls

@pmdevita Great to hear that! :) The most crucial things are: * reverse relation fields that are added to models in runtime are not detected * ormar is changing the...

PostgresSyntaxError when save_related() pk only model

Can you provide a snippet to reproduce (i.e. what is your data where you define the related models)?

Added fk_name parameter to ormar.ForeignKey

There are missing tests. Also, I believe it will fail with inheritance as you would end up with two models with the same fk name.

This project is maintained?

Hi , I was in a need of something similar an created ormar -> you can check it out: https://github.com/collerek/ormar. I plan to both maintain and further develop it -...

Removing relation child while updating nullable fk as None

Hi, Can you add a test that fails now and that this issue fixes? Can be based on #1229 (without fastapi part, just ormar code is enough). Please place it...