ormar Removing relation child while updating nullable fk as None

Fixes #1229

Removing relation child while updating nullable fk as None in descriptors.py->RelationDescriptor

Ran the test cases locally using pytest -svv --cov=ormar --cov=tests --cov-fail-under=100 --cov-report=term-missing

All test cases passed

Nov 24 '23 20:11 amit12297

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3a206dd) 100.00% compared to head (57ab550) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #1230   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          201       201           
  Lines        16647     16659   +12     
=========================================
+ Hits         16647     16659   +12

Files	Coverage Δ
ormar/models/descriptors/descriptors.py	`100.00% <100.00%> (ø)`
tests/test_relations/test_foreign_keys.py	`100.00% <100.00%> (ø)`

Nov 25 '23 08:11 codecov-commenter

Hi,

Can you add a test that fails now and that this issue fixes? Can be based on #1229 (without fastapi part, just ormar code is enough). Please place it under tests/test_relations/test_foreign_keys.py as an additional test case.

Dec 06 '23 11:12 collerek

Hi,

Can you add a test that fails now and that this issue fixes? Can be based on #1229 (without fastapi part, just ormar code is enough). Please place it under tests/test_relations/test_foreign_keys.py as an additional test case.

Hi @collerek,

I added the test-case. It fails without my changes and is passing with my changes. Please suggest if I can give a better name to the test-case.

Here are the screenshots-

Failing without my changes: Screenshot 2023-12-07 at 1 08 33 AM Screenshot 2023-12-07 at 1 21 18 AM