collerek comments

Results 113 comments of


                                            collerek

Upgrade to SQLAlchemy 2

BTW it seems like a significant performance degradation over the previous version, we need to check if caching is working as described here: https://docs.sqlalchemy.org/en/20/faq/performance.html

Fix add_field_serializer_for_reverse_relations clearing validators

sorry for the late answer, can you add a test that would fail before and this change fixes?

Fix add_field_serializer_for_reverse_relations clearing validators

Hi, you didn't allow me to push to your fork, so can you please apply https://github.com/collerek/ormar/commit/b1d803a945687d37e6101e981615daaacbf859f5 on your pr (fixes test with default value)

Fix add_field_serializer_for_reverse_relations clearing validators

> The missing coverage is due to a block that was not changed in this PR. Seems to be a preexisting issue. Yeah I know but since I cannot edit...

build(deps-dev): bump watchdog from 3.0.0 to 4.0.1

@dependabot rebase

Support python 3.12

Please also add 3.12 to the test matrix in https://github.com/collerek/ormar/blob/1cd9204665767e05b480fc3fbfd9d820a340772b/.github/workflows/test-package.yml#L20

Support python 3.12

> Regarding the failed test, `distutils` was deprecated in Python 3.10 and removed in Python 3.12. The test job pins poetry to 1.4.2, but the first version of poetry that...

That's still installing `2.5.3` in tests, might be cross dependency with pydantic-extra or something else. As it mingles with pydantic internals each upper version should be checked. Edit: see that...

copy translate_list_to_dict default argument

Thanks a lot! :)

Request ormar to support pydantic 2.6, 2.7, ...

Pin bumped in #1388 will release soon