Colin White

Results 157 comments of Colin White

Might be worth stripping all calls functions in `Preconditions.kt` since the nullability for our code is already enforced at compile time and those functions are called very frequently. This is...

I think we should probably update the components to apply that property as margin instead. Having `padding` as a property and `Modifier.margin()` isn't great from an API perspective. The downside...

Thanks for taking a stab at this - unfortunately looks like the tests are failing with a `StackOverflowError`. You can run the tests locally using `./test.sh`.

Sorry for the delay on merging this. After thinking about this I think we might want to handle Windows file paths a different way. Changing the `Uri` class to handle...

@Caij Thanks for creating this PR - I ended up using some of your code in the final fix [here](https://github.com/coil-kt/coil/pull/2404), which should be available in the next alpha release.

Using `captureRoboImage` [works great](https://github.com/coil-kt/coil/pull/1685), thanks!

@nift4 Does wrapping your placeholder in a [`ScaleDrawable`](https://github.com/coil-kt/coil/blob/main/coil-gif/src/main/java/coil3/gif/ScaleDrawable.kt) solve this issue? I'd prefer to avoid adding a new API for this as it's an uncommon use case and it's possible...

Yep, I think it's fair to move it if we're recommending it for this use case. It's a small class and R8 will easily strip it if it's unused.

+1 for a standard interface - similar to `ChangeListener`.

I think this is something we could support (no timeline) as I believe Skiko/Skia already support decoding GIF frames. We'd just need someone to write a custom `Decoder` that uses...