Colin White

Results 154 comments of Colin White

Yep, this is currently intended behaviour as Coil doesn't take `maxHeight` into account (neither do other image loaders). We could potentially add support for this, but it's a behaviour change...

Coil 1.4.0 constrained the max output image size in this case to the size of the display, which had some other issues.

I think this is best handled by adding a `filenameFactory` (or similar) param to `DiskCache.Builder` so it's possible to set a custom `DiskCache.Key -> String` function for creating the file...

Sorry, I was proposing a potential API as this doesn't exist yet. After thinking about this more we'd have to be careful adding this API as changing the `filenameFactory`'s logic...

We should definitely support this. I don't think we can change the existing default behaviour unfortunately, but we could probably introduce a special constant that triggers this behaviour.

We could map the `Int`s to `Uri`s (similar to how we handle Android res IDs), but we'll still need a fetcher to convert the `Uri` into an `ImageSource`.

This is now supported as of `3.0.0-alpha10`.

Thanks for the repro project! Will take a look unless someone beats me to it.

Thanks for taking a look! The `drawSize` call looks to be working correctly as we want it to return `null` until it's given a valid size. I'd check out [here](https://github.com/coil-kt/coil/blob/main/coil-compose-base/src/main/java/coil/compose/AsyncImage.kt#L207)...