Colin Ross comments

Results 8 comments of


                                            Colin Ross

FactoryBot introduces ActiveSupport monkey patching to Hashes

FactoryBot depends on ActiveSupport, and specifically calls in parts of it's core_ext for `Hash` objects. This isn't a bug.

Add find_or_create_by Method

I believe that is somewhat intended. Sharing data between test runs is usually a code smell, either in the runtime code or your testing code. Assuming you have some level...

Feature request: attribute scoped sequence

Does your priority HAVE to start with 1 under each scope? if not, just use a normal (inline) sequence.

Add config authentication_failure_route to customize redirect route

Currently, failures are handled by the failure_app which could be a full rack app, or just a lama defined in the routes (`devise_for`). This would allow you do whatever you...

Allow skipping password length validation if `password_length: nil (or false)`

If you are implementing your own validations, why are you including `:validatable` in the devise config?

Traits that imply other ones can cause double running of callbacks

The aggregate callbacks get a `flatten.compact` but maybe the context is making them dissimilar? We could wrap them in a registry like the decorators, but then we would need to...

Traits that imply other ones can cause double running of callbacks

Looks promising to me.

rails g avo:all_resources should work only for models that inherit from ApplicationRecord

While I agree it should not pick up modules, I don't see it picking up a defined class that implements `ActiveModel::Model` as a bug, as this behavior is largely in-line...