obsidian-things icon indicating copy to clipboard operation
obsidian-things copied to clipboard

fix: use `code-block` in style settings to change code blocks colour

Open Fricounet opened this issue 2 years ago • 1 comments

The current Style Settings for updating the code blocks was not referring to the correct CSS variable (I think so at least). This PR fix this behaviour.

For example: image image

Fricounet avatar Aug 13 '22 10:08 Fricounet

Hey, thanks for creating the PR. This setting here actually refers to styling the font color of these blockquotes:

Screen Shot 2022-08-14 at 5 51 19 PM

I don't have a style setting for code block color, though can consider adding one if it's something you really need. Thanks!

colineckert avatar Aug 15 '22 00:08 colineckert

Oh! My bad, I was not aware these blockquotes existed in Obsidian so I thought there were linked to the ` you can use to create inline code blocks ^^

If you are fine with the customisation of code blocks, I feel like it could be a nice addition. In my opinion, the current color used does not stand out much and is pretty easy to miss when scrolling the text.

I will revert my change and push a commit to introduce their customisation. I was not sure how to implement that since the color is different between the dark and lights themes. I tried to do something similar as what you did for 'Tag background color' but tell me if that is not how it should be done.

And if you do not want to implement this, feel free to close my PR :D

Fricounet avatar Aug 17 '22 19:08 Fricounet

Thanks, @Fricounet - this is a great addition to the customization options! I appreciate the contribution!

colineckert avatar Aug 27 '22 22:08 colineckert