obsidian-things icon indicating copy to clipboard operation
obsidian-things copied to clipboard

Font size adjustment not working for me (using latest version of Things)

Open richardlm opened this issue 2 years ago • 11 comments

Hi

I know there have been a few issues raised about font size adjustment and it is now meant to be fixed, but it does not work for me.

The 'Font Size' slider under 'Appearance' has no effect at all on the Things theme, and I cannot see a setting in 'Style Settings' that changes the main font size. There is an entry for the sidebar and tag font size that works, but not the main text on a page.

The 'Font Size' slider works on the Default theme nicely in that it adjusts all elements appropriately.

I have disabled all plug-ins to check for any clash, but the problem still remains.

Any hints on how to debug this?

Thanks.

richardlm avatar Apr 06 '22 17:04 richardlm

I am having this problem too, it just started today for me. On windows 11 if that helps.

tildejustin avatar Apr 12 '22 12:04 tildejustin

Same problem on macOS I updated the app

sowenjub avatar Apr 12 '22 15:04 sowenjub

I think it was an app update, i tried Things versions down to 1.6.8 and no amount of version downgrading fixed the problem

tildejustin avatar Apr 12 '22 15:04 tildejustin

have same problem 🙋‍♂️

SoldMeteor avatar Apr 12 '22 15:04 SoldMeteor

Hey all! Yes, there was an app update that broke the font slider functionality for the theme. I pushed a quick fix for updating the overall font size via the Style Settings plugin (use Things v1.7.1). You can find it under Things Theme > Typography (default is 1em) and use it to increase the font size in editor panes of all text (body & headers).

Screen Shot 2022-04-12 at 10 14 31 AM

Working on getting the slider fixed asap. Thanks!

colineckert avatar Apr 12 '22 17:04 colineckert

Thank you @colineckert for being so responsive, much appreciated! 🚀🤩🙌

sowenjub avatar Apr 12 '22 18:04 sowenjub

Many thanks Colin 🙏

richardlm avatar Apr 14 '22 15:04 richardlm

I thought of this issue again and was comparing the code of minimal to things, and I found that in minimal the code for font-adaptive-normal is, --font-adaptive-normal: var(--font-text-size); , whereas in obsidian-things it's --font-adaptive-normal: var(--font-normal); and font-normal is hardcoded to 16px. If you use the minimal version in obsidian things, then font size is respected in settings again. I'm not very good at css so I don't know what why this was set like this, but it seem to fix the issue.

tildejustin avatar Aug 04 '22 03:08 tildejustin

I had it working, but that was with a lot of styles disabled in the inspector so I can't reproduce it. I might report back tomorrow if I find a working fix.

tildejustin avatar Aug 04 '22 03:08 tildejustin

--preview-font-size: var(--editor-font-size); has to be deleted as well. This only works for view mode.

tildejustin avatar Aug 04 '22 04:08 tildejustin

Change file extension to css and put in your snippets folder, should make font sizing work again. Very hacked together so someone might want to take a look at it. (fontfix.txt)

tildejustin avatar Aug 04 '22 15:08 tildejustin

Change file extension to css and put in your snippets folder, should make font sizing work again. Very hacked together so someone might want to take a look at it. (fontfix.txt)

It's working now, thanks.

SheepTAO avatar Aug 25 '22 13:08 SheepTAO

Hey all, thank you so much for continuing to post in this issue thread, sharing tips with each other, and helping improve the theme. I've finally fixed this issue and is live in the latest theme. Just update your Things theme and the font size slider should be working :) pls reopen the issue if you experience any bugs, thanks!

colineckert avatar Aug 27 '22 23:08 colineckert