obsidian-things icon indicating copy to clipboard operation
obsidian-things copied to clipboard

Code Syntax highlighting is messed up all of a sudden.

Open omarcevi opened this issue 1 year ago • 7 comments

Hello,

After updating to the last version of the theme, my code blocks syntax highlighting is all messed up and showing mainly 1 colour. Screenshot 2023-09-02 at 20 51 29

anybody facing the same issue?

Edit: This was the syntax before i updated Screenshot 2023-09-02 at 20 59 44

omarcevi avatar Sep 02 '23 17:09 omarcevi

Yeah so i manually reverted to an older version (2.0.0) and the syntax was back normal.

omarcevi avatar Sep 02 '23 18:09 omarcevi

hey @lukasschwab and @omarcevi, thanks for creating the issue. i just released a new version of the theme that should address some of your concerns with syntax highlighting: https://github.com/colineckert/obsidian-things/releases/tag/2.1.15

lmk if this looks better and if so, pls close this issue. thanks!

colineckert avatar Sep 09 '23 19:09 colineckert

Hi @colineckert — this is my first time seeing this thread. Was there something you wanted me to look at?

lukasschwab avatar Sep 09 '23 22:09 lukasschwab

oops sorry @lukasschwab. you're good, i @ you by accident.

colineckert avatar Sep 09 '23 22:09 colineckert

Yeah its fixed now closing the ticket :)

omarcevi avatar Sep 28 '23 05:09 omarcevi

Hello again, the code blocks are all fine in the editing view, but they're not in the reading view. It affects the publish feature. the syntax coloring is not the same.

omarcevi avatar Sep 28 '23 15:09 omarcevi

I can confirm the issue. Editing is fine, viewing is single-color (red) only. Would be great to have this fixed.

Edit: I just realized that it's depending on the language. So it's only half-broken :-) See attached screenshots Edit2: I think it takes two different sources for the coloring. The "-m" which has a darker brown in edit-mode is not colored differently in bash. Edit3: My iterm2 with https://github.com/zsh-users/zsh-syntax-highlighting renders different colors. Maybee it could be nice to select the desired "color-scheeme"? but I think I'm asking too much here...

CleanShot 2024-04-10 at 08 15 58@2x CleanShot 2024-04-10 at 08 16 12@2x CleanShot 2024-04-10 at 08 34 39@2x

svenblum avatar Apr 10 '24 06:04 svenblum