Results 48 comments of Charles Leifer

I'd accept the README patch, but will pass on the changes to the javascript.

It looks like the table name is missing from the ALTER TABLE statement. It should theoretically appear before "(parent_type_id)".

I've typically preferred to point directly to the function on the view class, rather than relying on a name/getattr. Aside from that it looks good. Do all tests pass, and...

This looks fantastic. Do you mind adding tests for the new behaviors? Perhaps a custom action and then testing to ensure it works correctly?

Interesting, I had no idea this would work! Do all tests pass and everything look right to you?

Thanks for posting your findings, I think your approach looks sane but not knowing your application as well as you do, I'm not sure I can comment on how correct...

I believe when instantiating your `Admin` you pass in a different `"prefix"`, e.g. ``` python admin = Admin(app, auth, prefix='/my-awesome-peewee-admin) ```

You should be able to override the templates as needed, e.g. the `pre_content` block: https://github.com/coleifer/flask-peewee/blob/master/flask_peewee/templates/admin/models/base.html But it definitely would be easier with a simple flag. Thanks for the suggestion.

I need to fix this. Will try and get things cleaned up in the next day or two.