Chris Harwood comments

Results 41 comments of


                                            Chris Harwood

Allow dynamic import for Node.js >=12.17 <13 || >=13.2

@ljharb > > > This handles when the syntax is supported, but it seems useful to also warn on node 13.2-13.6 where `import()` parses but doesn't ever succeed? Does anything...

Allow dynamic import for Node.js >=12.17 <13 || >=13.2

@ljharb > I can't think of any other example, in node or browsers, of syntax that parses but doesn't function :-) 😂 Yeah it's a bit odd. It seems "safest"...

Allow dynamic import for Node.js >=12.17 <13 || >=13.2

/bump @mysticatea

Allow dynamic import for Node.js >=12.17 <13 || >=13.2

Just updated from upstream to resolve conflicts.

Allow dynamic import for Node.js >=12.17 <13 || >=13.2

Something changed with the tests, so I'll have to go fix the test failures, too. Will have to come back to do that later.

Allow dynamic import for Node.js >=12.17 <13 || >=13.2

Okay I have _no_ idea what happened with that last rebase, but we back now. All tests passing and parts of my changes not just missing. Looking at some of...

Allow dynamic import for Node.js >=12.17 <13 || >=13.2

Chiming in to let you guys know I'm still here, too! If there's any movement, I will make sure it's all rebased up and tests are still passing. Thanks for...

Allow dynamic import for Node.js >=12.17 <13 || >=13.2

I've been thinking about this myself. I feel like there's an amount of diligence that must be done in attempting to maintain the agency of the original author of a...

Allow dynamic import for Node.js >=12.17 <13 || >=13.2

> > That said, I'd be happy to port this PR and these changes over there, if you'd like. > > @nazrhyn Yes please! Done! 🙇 I wonder if I...

Allow dynamic import for Node.js >=12.17 <13 || >=13.2

> This PR is no longer useful as-is, but now that [weiran-zsd#13](https://github.com/weiran-zsd/eslint-plugin-node/pull/13) is merged, you could force update your branch back to where it was on the off chance this...