Sasha Avalon

Results 12 comments of Sasha Avalon

This would be great. I'm having some trouble getting this to work, where it did in the old `rules_js` repo. I defined a custom plugin: `tools/bazel/ts_proto_compile/BUILD.bazel`: ```starlark load("@rules_proto_grpc//:defs.bzl", "proto_plugin") proto_plugin(...

I think I can see part of the issue - the file is actually a shell script to run node. Setting the `tool` to the new form of `js_binary` should...

I came up with a fix for this, but it involves loading the NodeJS binary into the container twice - once with a loader script that forces an immediate exit...

Following up - found a better way to do it without two `nodejs_image` rules, which means `node` only ends up being in the final image once, but it involves patching...

This PR helps our team a lot. It would be great to find a way to re-land it in the next release. Because all our developers use linux x64, we've...

Updated in https://github.com/rules-proto-grpc/rules_proto_grpc/pull/210.

Related: https://github.com/rules-proto-grpc/rules_proto_grpc/pull/211

We have a similar issue to this - we want to replace `node` with `nodemon`, for example, in JS rules.

We need this for our use case as well. We have a private repo, but use GitHub Actions runners to deploy to our various environments (we have self-hosted runners on...