Tracy Ward

Results 32 comments of Tracy Ward

Anyone have opinions on merging as-is and putting the style icon issue in a new issue/pr?

> Has anyone tried renaming the asset to `Horizon_Single.png`? Unlike Techno styles, the proposed Horizon styles [don't include numbers](https://github.com/stepmania/stepmania/blob/01db6d7301f19bdcbd597840044ef4d455007b8f/src/GameConstantsAndTypes.h#L115-L116). Well, that indeed fixes it for single. ~~And, we already had...

Was it actually built with ffmpeg?

Yeah, you should see MovieTexture_FFMpeg.cpp, provided your logging includes source filenames.

Context: https://github.com/stepmania/stepmania/blob/5_1-new/src/NotesLoaderSM.cpp#L552

I don't have time to fully study the code at the moment, but it looks like the for loop before the quoted section would have already advanced the iterator to...

If anything, I think the two lines (579 and 580) should be swapped. We're in this if block because the for loop ended with beat 0 having a bpm of...

Thinking about it a bit more, the for loop should probably keep going until it hits the first non-zero bpm after beat 0, as someone might have put in some...

> it should remove ibpm++ this line, or will raise bug @acgleader Can you provide more information on the bug that will be raised?

This does appear to be another result from switching from C conversion functions over to similar c++ functions. It feels like a bit of a can of worms that shouldn't...