Zexin Li ^_^
Zexin Li ^_^
Hi @andsel I tried to optimize CNode.copy, but it seems impossible. Because this itself may be a false proposition. CAS is a good idea of concurrency lock-free, but it doesn't...
> 85 minutes for 600k subscriptions seems very slow. > > Could you give us some statistics on those subscriptions? How many clients, how many topics, how deep are those...
> Did a quick profile, and I suspect you have a very flat tree. > Currently CNode is very inefficient when adding items to such a flat tree: > >...
> I had a quick go at it in #630 > Massively improves performance, though it will still slow down when there are many children. ### Description data structure for...
Hi @andsel I found the root cause of this problem( When there are a lot of children and subscriptions, CNode.copy will be slow) , you can to run [amzexin/moquette fix629_bug-reproduce...
> It is missing the option for 'path'? yes.
> This is already fixed by #630, please @timeway could you check if it solves your issue and in case close the PR please 🙏 ? I use the latest...
maybe add filedConnection() to Session.java ```java boolean filedConnection() { return assignState(Session.SessionStatus.CONNECTING, Session.SessionStatus.DISCONNECTED); } ``` and add bindedSession.filedConnection() before MQTTConnection.java:321 ```java bindedSession.filedConnection(); sessionRegistry.connectionClosed(bindedSession); // MQTTConnection.java:321 ```
> @blankbro thanks for reporting this. Do you have some simple way to test and reproduce locally the same error? 😅 No, I don't.