codemob
codemob
> Any way you can fix the commit history on this? Might not be a big deal since we squash on merge but it makes the PR a bit harder...
> I think it would make more sense to use the actual quad model instead. Sure, I'll try that.
> The collision model is deliberately imprecise. I think it would make more sense to use the actual quad model instead. Done!
> please use a descriptive title Done.
For some reason the player physics has changed a bit though lol
> I think you should split this PR into smaller pieces How would you suggest splitting it up then?
> Please reabse to update to the new zig version Done
> we should have them as a one optional argument at the end of the function That isn't the standard for zig, this isn't c.
> In general parameterizing functions like this is discouraged in clean code guidelines and would mean function should be split into smaller ones Maybe, but here you would end up...
You could check to see how low the player is below the heightmap perhaps.