Edward-Precious Omegbu

icon indicating a website link https://portfolio-codegiyu.vercel.app icon indicating an email [email protected]

icon company Pinpoint Global icon location Abuja, Nigeria icon location Frontend web developer...NextJS, ReactJS, JavaScript, TypeScript, SCSS, TailwindCSS, HTML, CSS, Node.js and Express.js.

Results 9 comments of Edward-Precious Omegbu

Numeric keys disallowed in object expressions

I have a lot of experience working with types in typescript and I believe I can smoothly extend the object type to also allow numbers as object keys. I hope...

Numeric keys disallowed in object expressions

@josdejong yes I would like to take a shot at it

Numeric keys disallowed in object expressions

You're welcome

Numeric keys disallowed in object expressions

@josdejong a PR is open and ready for review

fix: numeric literals can be set as object keys and used to access objects

@josdejong ready for review

fix: numeric literals can be set as object keys and used to access objects

Understood...I'll remove the unnecessary eslint, prettier suggestions and whitespace improvement and add tests for the parser adjustments I've made

fix: numeric literals can be set as object keys and used to access objects

@gwhitney unnecessary changes removed and unit test suites added....ready for review

fix: numeric literals can be set as object keys and used to access objects

> @codegiyu did you see my last feedback on this PR? Please let me know if you need more pointers or help. I'm so sorry, I didn't notice your feedback...

fix: numeric literals can be set as object keys and used to access objects

Thank you for the guide on a direction on modifying a few of the methods....I'll get it sorted as much as I can before midnight tonight