Adrian Cole

Results 2042 comments of Adrian Cole

Hi, Jorge. Is this actually a zipkin 3 issue? or could it be implemented with the existing apis just possibly some other config? Want to parition (pun intended) things that...

@reta noticed this again ``` Error: zipkin2.junit5.ZipkinExtensionTest.postSpans_disconnectDuringBody -- Time elapsed: 0.024 s vitest [INFO] [INFO] [INFO] Results: [INFO] Error: Errors: Error: ZipkinExtensionTest.postSpans_disconnectDuringBody:123->assertPostSpansV1Success:176->postSpansV1:168 » Connect Failed to connect to localhost/[0:0:0:0:0:0:0:1]:45181 [INFO]...

https://github.com/openzipkin/zipkin/pull/2807 single span version

here's an example recent PR for langchaingo https://github.com/tmc/langchaingo/pull/944

and soon by ENV 🤞 https://github.com/ollama/ollama/pull/8938

added a follow-up here so that it is easy like others to use in Docker https://github.com/llamastack/llama-stack/pull/4281

I won't have time to review this, possibly for 2 weeks due to time off. maybe ping someone else

@jamesmoessis mind helping do a review pass? I suspect we can cut a release tag once this is in. cc @basvanbeek in case you have any objections or additions to...

@CodePrometheus mind starting the good dep hygiene practice with a go.mod for this one? In other projects I use a replace to the parent directory for the main library dep....

If you feel industrious, you could also be the first to use an integration test here via testcontainers. Since this is a module there would be low risk on the...