Adrian Cole

Results 2042 comments of Adrian Cole

here's some charts for a 100s run of brave-webmvc-example against latest docker with 2.16.1 and ES 7 (ES_HTTP_LOGGING=basic) ![Screenshot 2019-08-17 at 8 59 26 PM](https://user-images.githubusercontent.com/64215/63212072-14066600-c132-11e9-87e3-00560e58addd.png) ![Screenshot 2019-08-17 at 8 59...

here's the same run, I only changed the image of zipkin to 2.15.0 leaving the ES image etc exactly the same. ![Screenshot 2019-08-17 at 9 06 31 PM](https://user-images.githubusercontent.com/64215/63212180-08676f00-c133-11e9-8d08-1ec85fd5cc1f.png) ![Screenshot 2019-08-17...

I will now do the same without basic on, just in case something about basic logging is using a lot of memory

this is 2.16.1 with complete defaults, no ES logging. ![Screenshot 2019-08-17 at 9 15 49 PM](https://user-images.githubusercontent.com/64215/63212263-5630a700-c134-11e9-9794-80f890a5d63f.png) ![Screenshot 2019-08-17 at 9 16 07 PM](https://user-images.githubusercontent.com/64215/63212266-58930100-c134-11e9-8986-8c3f40b46621.png) ![Screenshot 2019-08-17 at 9 16 20 PM](https://user-images.githubusercontent.com/64215/63212267-5af55b00-c134-11e9-9c65-f8b971d97d73.png)...

@anuraaga @trustin can I leave this one to you to look into? I don't want us to do a release announcement saying we did all this stuff to make things...

and btw in both cases we were using armeria server. the main thing we did was change the elasticsearch client to use armeria vs okhttp. It ended up a lot...

ok thanks. this seems like great progress. also that's right about before we had a semaphore which would have dropped immediately. wrt the callbacks, if we need to temporarily remove...

Thanks for the progress, @anuraaga. cc also @trustin Here's the current master vs 2.15.0 on the same burst of 100s in the same docker etc everything. It is much much...

I created an issue to make troubleshooting easier though it isn't hard to start frontend/backend and smack it with wrk (agreed current approach doesn't help in cloud but we aren't...

@jcarres-mdsol haha this is a parking lot at the moment. As long as zipkin keeps going, we can eventually expect a v3.