Adrian Cole

Results 2042 comments of Adrian Cole

> I can volunteer to do this as I am interested on the schema. Should I just open a PR to https://github.com/openzipkin/zipkin-api? I guess it would be also interesting if...

sorry I meant like this. https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/Span.java#L184 I expect play should have access to precise endpoint details but I also might be wrong. another way is to simply not add the...

curious on this, would we need to do something to hook brave Tracing.currentTraceContext() to the akka dispatcher's executor somehow? It seems like if we didn't asynchronous code would lose the...

Naoki, so one thing to experiment with is using Brave's log4j or slf4j integration. If an async callback doesn't show up in the logs then the context isn't being used...

> this is super funny: yes, no PR is complete without unrelated bruising from lint checkers ;)

ok! finally time to ship this 👍

@jorgheymans wonder if there are tags or otherwise we can use for things you've processed and are awaiting this or that. ex even if it is ok close in favor...

@yurishkuro nothing in the CQL deserializes thrift. While it is true that we store these dates, they aren't used anywhere except to make epochDayMillis, which could be done directly. I'd...