Adrian Cole

maybe the javadoc are not rendering for you. I think it is explained exactly including how to handle conditional here https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/Tracer.java#L184 On Wed, Jul 10, 2019, 3:57 PM Simão Mata...

also here is the correct code which can be copy paste until such time as the http abstraction is implemented here.. https://github.com/openzipkin/brave/blob/master/instrumentation/http/src/main/java/brave/http/HttpServerHandler.java#L96

sorry to be more literal, both old and new are broken code. scala variant of this can fix it. ```java Span nextSpan(TraceContextOrSamplingFlags extracted, Req request) { Boolean sampled = extracted.sampled();...

sorry actually this code looks ok because you don't have http sampler anyway yet. it does need test case though

been a long time. just rebased the project so it has CI etc

@seanyinx as it has been a few years, let me know if you want to continue this. If so, try to rebase on new commits. Otherwise, let's close it out.

note: schema registry is confluent license I think, not apache, iiuc. That said we also make an optional mysqldb image which is also not ASL, though it is not constrained...

Also I *think* if I understand it right.. some products who use SR have the option not to, as long as they have a copy of the schema. I think...

personally keen on at least the avro part as an option (even knowing the format is higher overhead), as like you said certain features would be available which otherwise aren't....

I see.. is there a site who's interested in this specifically for zipkin? If not, might be less work and less special to experiment with a format we already support...