codefiles

After some more research I would say the following code comment is not accurate. https://github.com/archlinux/archinstall/blob/624d3d5bf64b05388623d817454389832d1711af/archinstall/scripts/guided.py#L196-L198 Here is what is wrong with the code comment. 1. `profiles_bck` should be `default_profiles` 2....

My proposed fix in https://github.com/archlinux/archinstall/issues/1971#issuecomment-1666673560: > Filtering the partitions to be validated to only partitions with a status of _modify_ (`ModificationStatus.Modify`) or _create_ (`ModificationStatus.Create`) should fix this unless there is...

The `parted.devices` dict does not contain a `17` key. [1] This is defined in parted as `PED_DEVICE_MD`, [2] a RAID device. ### Example ```python import parted for key, value in...

Let's not merge this yet. I feel that it is stale now so I am changing this to a draft till I review it again.

@eskiq would you please reopen this issue since it has not been resolved yet?

Here is a minimal solution to get this working for GRUB: https://github.com/codefiles/archinstall/commit/b6721635319c17b1d1715f10dfa19437dd4a2638

> Honestly, I don't know why my PR wasn't reviewed and/or merged a long time ago. I didn't see anything wrong with it (iirc it worked fine when I tested...

Here is code you lost when you force-pushed from be87a22 to 4b6a6c0: https://github.com/archlinux/archinstall/commit/be87a222c623972c8af4fa077795ba5485c0851f#diff-283d51110d004467e254215ad93e4dfcf0188beb22d9f878bb7088c12076dd2eR748-R751

Relevant: https://gitlab.archlinux.org/archlinux/packaging/packages/grub/-/issues/5

> There's always something, isn't there 🙄 Yep. > I just tried to boot from a live USB and encountered the error described in that issue. Oh, the ISO uses...