codefiles

~~I can't get the flake8 linting to pass. What would be the acceptable way to format the long if statement in `examples/guided.py`?~~ Edit: I misunderstood the output of flake8, the...

Updated this pull request to use locales instead of locale in preparation of pull request to add support for https://github.com/archlinux/archinstall/issues/1435.

Oh it absolutely is a hacky workaround. Revisiting this after those improvements is good with me.

> mhm, `termios.ONLCR`? @kamiccolo, how about this? Reproduce the issue: ```python import os import pty import time pid, fd = pty.fork() if pid == 0: os.execv('/usr/bin/printf', ['printf', 'foo\nbar\n']) else: time.sleep(1)...

> But I think setting the tty attribute is the cleanest approach? Checking the output of the examples below will show that `onlcr` is enabled in both cases but carriage...

> `subprocess` was not working reliably with `machinectl`, `ssh` or any other process that was forking their `stdin` handlers as well as detecting changes in running state of the executable....

I understand now that the desire is for `archinstall.SysCommand()` to work with any command and therefore it is designed to use a pseudoterminal. A possible alternative to interacting with `ssh`...

This issue has not been solved. The issue was inadvertently fixed for Btrfs in commit 00b0ae7 but the last line of the fstab file will be missing a newline (`\n`)....

> May be it's a little bug in the archinstall, perhaps the /etc/vconsole.conf is updated only after using mkinitcpio? You are correct. The mkinitcpio call will occur in `Installer.minimal_installation()` or...

Would you mind reopening the issue? Thanks. Here is what `/etc/vconsole.conf` looks like after `set_keyboard_language()` when the keymap is `us`. ``` # Written by systemd-localed(8) or systemd-firstboot(1), read by systemd-localed...