Ivan
Ivan
The increment of `NewSampleFromTrail` sounds fine because we added the following new lines in the atlas branch: https://github.com/grafana/k6/blob/be8ca6fe61c5961d83399a76f49d5aee07e94a91/output/cloud/data.go#L114-L118
I've seen it some times ``` --- FAIL: TestExecutionInfoVUSharing (4.07s) k6execution_test.go:146: Error Trace: k6execution_test.go:146 Error: Not equal: expected: 0x9 actual : 0xa Test: TestExecutionInfoVUSharing k6execution_test.go:148: Error Trace: k6execution_test.go:148 Error: Not...
One more ``` --- FAIL: TestClient (0.01s) --- FAIL: TestClient/ReflectUnregistered (0.02s) client_test.go:671: Error Trace: /home/runner/work/k6/k6/js/modules/k6/grpc/client_test.go:671 /home/runner/work/k6/k6/js/modules/k6/grpc/client_test.go:725 Error: "GoError: can't list services: can't send request: EOF at reflect.methodValueCall (native)" does not...
Hi @tbourrely, thanks for your contribution. :pray: I think a better place for this code could be closer to the TLS configuration initialisation: https://github.com/grafana/k6/blob/e09bb87277865d668586429eee97158fbbfc58e5/js/runner.go#L169-L177 You can test checking the p95...
Now you remember me that it has a strong dependency from the OS I would prefer to have it in the cmd package, where the `buildTestRunState` method seems to me...
Hi @tbourrely, this seems ready to be reviewed again. Can you rebase the branch and resolve the conflict, please? We would like to include this at the beginning of the...
Hi @amelkikh, did you hit some sort of issues implementing the suggestion? Can I help in some way? Thanks.
Hi @amelkikh, thanks for your commitment and for letting us know. I hope we will see you as a contributor again in the future.
@olegbespalov can you please comment on the new PR?
Yes, we are going to rollback this PR to the previous history and close then move in two more defined PRs.