Hari Sankar

Results 5 comments of Hari Sankar

Proposal Please re-state the problem that we are trying to solve in this issue : Concierge video download button open the video in another tab( since the video URL is...

Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~01881e3af3a211f8e3

Hi @sobitneupane , there is a fallback present in the code to open the video/image in another tab in case of CORS issue.

@sobitneupane Here is the [permalink ](https://github.com/Expensify/App/blob/48b80f65e80d304965cbeb3573d7d6678fb9bd3a/src/libs/fileDownload/DownloadUtils.ts#L71) to the fallback code. ```javascript if (onDownloadFailed) { onDownloadFailed(); } else { // file could not be downloaded, open sourceURL in new tab Link.openExternalLink(url);...

@sobitneupane , I second your thought, there is no need to relay on the fallback if you expected CORS issue on all downloads. If you want allow this download feature...