craft

craft copied to clipboard


Hamms

in https://studio.code.org/s/aquatic/stage/1/puzzle/11, the static conduit image looks like it has some visual glitches; the animated version of the thumbnail makes it clear what's going on, but it's not at all...

Hamms

@davidsbailey made a [fix](https://github.com/code-dot-org/code-dot-org/pull/26043) to use Selenium to click elements rather than jQuery. A small piece of that fix needed to be [undone](https://github.com/code-dot-org/code-dot-org/pull/26098) in order to get `i18n.feature` to pass....

maddiedierker

Just for consistency. It can be our existing readme. https://www.npmjs.com/package/@code-dot-org/craft 

islemaster

On all levels, iOS12: 

ryansloan

Fix z-order clipping of boat oars

1

Expected behavior:  Actual: 

joshlory

Optimize underwater music, add .ogg files

1

The added aquatic 01-03 mp3 files are much larger than previous years. We'll also need the .ogg version for our sound player. https://github.com/code-dot-org/craft/blob/5a8b2378b4bfb0e7d9d68de4b768ca947455e9df/src/assets/audio/ogg2mp3#L1-L2  The nether music from last year...

joshlory

Why are there two (that aren't always set consistently)?

joshlory

See https://github.com/code-dot-org/craft/issues/374#issuecomment-339499640. We've been approximating this with the "Invisible" block type, but this is fragile and breaks when we import new versions of Blocks.json. https://github.com/code-dot-org/craft/blob/ffb56b9281db1b3201c1e866856f12e319fd4ba9/src/js/game/LevelMVC/LevelBlock.js#L77-L82 On October 29, 2018 I...

joshlory

Merge "actionPlane" and "groundDecorationPlane"

1

See https://github.com/code-dot-org/craft/pull/507#pullrequestreview-165340120. We think this is a remnant from the first year, where action plane blocks were collideable, but decoration plane blocks were not.

joshlory