LloydZ

Results 20 comments of LloydZ

Maybe 3.6 testing should be skipped. I'm not sure if this implementation is what we want.

Thanks so much for your help! Everything's been updated now.

> hey there! > > > > lots of comments. mostly looking to clean up variable names and integrate better in the filter logic, can you review a refactoring I'm...

The latest code has been updated. Previously, it might have been because I was concerned that making too many alterations to the code would impact other functions. Thus, I attempted...

I continued to test the efficiency issue regarding text replacement. The added `remove_prefix` method in Python 3.9 might be a better choice, but Mako currently only minimally supports Python 3.8....

Python 3.14 includes some breaking changes about asyncio: [asyncio.get_event_loop()](https://docs.python.org/3.14/library/asyncio-eventloop.html#asyncio.get_event_loop) now raises a [RuntimeError](https://docs.python.org/3.14/library/exceptions.html#RuntimeError) if there is no current event loop, and no longer implicitly creates an event loop.

https://github.com/Thriftpy/thriftpy2/blob/88923d61fa995e615d51a67d333c7686cda2a764/thriftpy2/contrib/aio/server.py#L26-L27 should be ```python3 loop = asyncio.new_event_loop() asyncio.set_event_loop(loop) self.loop = asyncio.get_event_loop() ```