Support comprehensions inside functions when use strict_undefined flag.

[cocolato]

Fixes: https://github.com/sqlalchemy/mako/issues/320

Now the test code works as expected if strict_undefined is set to true:

from mako.template import Template

text = """
<%
    mydict = { 'foo': 1 }

    ## Uncomment the following line to workaround the error
    ##k = None
    def getkeys(x):
        return [ k for k in x.keys() ]
%>

${ ','.join( getkeys(mydict) ) }
"""

tmpl = Template(text=text, strict_undefined=True)
out = tmpl.render()
print(out)

output:

foo

[zzzeek]

wow I dig this, you're into mako now. great let's run the CI

[sqla-tester]

New Gerrit review created for change daffd3832b4adab291625e1e6efcdb56f8d0d05e: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5147

[zzzeek]

can you add a changelog file? thanks

[cocolato]

All has been updated.

[sqla-tester]

Patchset cc6a3e0694fb5615db2c3fec2cd23bc9e8a70066 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5147

[sqla-tester]

Michael Bayer (zzzeek) wrote:

thanks!

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5147

[sqla-tester]

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5147 has been merged. Congratulations! :)