Chris Nuernberger

Results 167 comments of Chris Nuernberger

In addition, We now need to use IAM roles on s3. This updates s3.clj to use them if no credentials are passed in.

I copied environ and exposed read-env. So we don't depend on this library any more. Then we have a system to save the program config to a variable that gets...

The work around for this is to use zstd - unfortunately lz4 is the default format for many of these pathways.

The go code manually resizes the dictionary - https://github.com/pierrec/lz4/blob/v4/reader.go#L180. The java code completely hides the dictionary leading to it being - I think - impossible to do with via simple...

I was able to (hopefully temporarily) work around this using [ffi bindings to the c library](https://github.com/techascent/tech.ml.dataset/blob/master/src/tech/v3/libs/arrow/liblz4.clj). Unfortunately this means users need to ensure liblz4 is available on their system.

Related exception in 3.2: ```console ERROR in (issue-201-incorrect-result-column-count) (System.java:-2) Uncaught exception, not in assertion. expected: nil actual: java.lang.ArrayIndexOutOfBoundsException: null at java.lang.System.arraycopy (System.java:-2) com.tdunning.math.stats.MergingDigest.merge (MergingDigest.java:302) com.tdunning.math.stats.MergingDigest.mergeNewValues (MergingDigest.java:291) com.tdunning.math.stats.MergingDigest.quantile (MergingDigest.java:661) ``` This...

I have a [test case](https://github.com/techascent/tech.ml.dataset/blob/1e292ab45e91a797fd5d55914505fb5176c2cdef/test/tech/v3/dataset/reductions_test.clj#L36) that does this about 3 times out of 100 if I run it in a loop. I am using version 3.2. I will get test...

100% main:HEAD fixes the test. I ran it many thousands of times just now and saw zero failures. The test case involves a Clojure datatframe library which means you would...

I looked through the issues and have them categorized and such. Here are my opinions- In short I think a point release is worth it now to get the fixes...