cmunkey
cmunkey
Can you add an analysis? Like the reason for the bug and how you are fixing it? From the changes, I can infer that the access is "deferred", moved from...
Yes, I did not know this was an exiting PR that was resurrected. Yes, I thought that keeping table logic where it was was more logical, DeferredWorkHelperImpl doesn't need to...
Maybe call it RandomUpdateStack instead of MyArrayStack.
java.util.Stack uses equals() for search, so maybe it is appropriate to use equals here for indexOf(). public synchronized int search(Object o)
Coding standard is 2 space indents. The unit test mainly tests the DumpExporter since the runnable does nothing. Maybe there needs to be an integration test that makes sure that...
Ignore these comments, I added them in line instead. > > @test(expected = HiveException.class) > > public void testDumpExporterWithParallelismFail() throws Exception { > > Shouldn't the error be AssertionError? Is...
Changes look fine to me.