Craig Morten

Results 43 comments of Craig Morten

> @cmorten are there any blockers for this PR? The cluster module is basically there but it relies on `process.send()` (REF: https://nodejs.org/api/process.html#processsendmessage-sendhandle-options-callback) and a few other bits on `process` that...

Hmm maybe https://github.com/denoland/deno/pull/13566… worst case can tidy up with some `notImplemented()` placeholders and is at least a step closer

> @cmorten Can you somehow get rid of circular dependency of `net.ts` -> `cluster.ts` -> `internal/cluster/child.ts` -> `net.ts`? > > (circular dependency can be checked with the command `./_tools/check_circular_deps.ts` Yeah...

Unix domain socket support as added in #2146 ```ts // demo.ts import net from "https://deno.land/std/node/net.ts"; import Web3 from "https://deno.land/x/web3/mod.ts"; const provider = new Web3.providers.IpcProvider( "/root/geth_data/geth.ipc", net ); const web3 =...

Will take a look if no-one is already on this?

TODO: - [ ] `socket.addMembership()` - [ ] `socket.addSourceSpecificMembership()` - [ ] `socket.dropMembership()` - [ ] `socket.dropSourceSpecificMembership()` - [ ] `socket.setBroadcast()` - [ ] `socket.setMulticastInterface()` - [ ] `socket.setMulticastLoopback()` -...

Agree with nested arrays, `forEach` provides equivalence. Personal main preference with `it.each` like syntax is the tagged template literal support which find far more elegant and expressive than an array...

Looking into this as part of https://github.com/denoland/deno_std/pull/2146 @bartlomieju have you made any headway / have any pointers as to what is causing the tests to hang? (No worries if not!)

Been trying to triage the issue using the `test-net-buffersize.js` test from Node. Side by side comparison (easier to spot divergence): ![Screenshot 2022-04-24 at 11 26 48](https://user-images.githubusercontent.com/11313985/164972199-61c7397a-0c97-44a7-8f6a-3977a247351e.png) ![Screenshot 2022-04-24 at 11...

Update on the above issue - resolved by implementing `LibuvStreamWrap.prototype.writev`. Curious that the `notImplemented(...)` error was getting swallowed... REF: https://github.com/denoland/deno_std/pull/2146/commits/6953b9356ec819595a082c13b7c1251a53ec77c0