Christoph M. Becker
Christoph M. Becker
Maybe @remicollet is still interested in uopz, and will have a look at this PR?
@Girgias, yes I do, but need to clean that up first. Bigger issue is that it seems that there will be no new release, so everybody would need to build...
We just need a tag in this repo, and a release on PECL (rest should work "automatically"). I might be able to tag, and probably also to release on PECL,...
> at a high level, can you talk about your end goals here ? Well, this was triggered by the discussion on https://github.com/php/php-src/pull/14877, where [`gdTestImageDiff()`](https://github.com/libgd/libgd/blob/77adfd27f776352e8095d98ef4902c28975d19af/tests/gdtest/gdtest.c#L423-L504) has been mentioned, including that...
> Obviously it's about skipping the revision check, but I don't understand where this check is performed, and why it depends on me There is [revcheck.php](https://github.com/php/doc-base/blob/master/scripts/revcheck.php) which is used by...
> Before I make changes, please answer one more question: is it not necessary to clean up the indentation in translation files in other languages? After all, it's one thing...
You are right about the warning/ValueError, but that is not specific to `getimagesize()` but rather happens when opening a stream: https://github.com/php/php-src/blob/6732b8892dcdb3928b69ba6351161759355d79ae/main/streams/streams.c#L2196-L2199 As such it would need to be documented for...
I'm not quite sure about this. Few if any of these are proper sentences, and as such terminating with a full-stop wouldn't be quite right, although there is at least...
Hmm, that article is apparently very old anyway. Maybe @macintoshplus has an idea where to link to instead?