Christoph M. Becker

> master...olape-git:cmsimple-xh:1.8.1_Cookie_2 Yes, looks good, but I would change the first five lines to: ````php $cookieSecure = !empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] != 'off'; ```` > Strict is definitely better. Right. There...

Well, you can activate the [`uopz.exit`](https://www.php.net/manual/en/uopz.configuration.php#ini.uopz.exit) INI directive to avoid that. Note that [changing the default behavior of uopz has been rejected](https://github.com/krakjoe/uopz/pull/106#issuecomment-460265968); adding a warning is probably off the table...

The bigger issue is with `E_STRICT`, since the constant is generally deprecated as of PHP 8.4.0, but we're using it at: https://github.com/cmsimple-xh/cmsimple-xh/blob/f3bb96dacf73370adb7dcc10fc503fc646235d12/cmsimple/functions.php#L1118-L1120 If debug mode is enabled, this triggers a...

Given my concerns raised in https://github.com/ThePHPF/pie-design/issues/27, I would appreciate to use the `pecl` namespace only for extensions hosted on https://github.com/php.

> […] and we should strive for getting rid of the name there as well. Ultimately, I would hope for 0 extensions under the name `pecl`. Most importantly, though, no...

I'm not sure what to do with TIFF support generally. Years ago [adding TIFF support to PHP](https://github.com/php/php-src/pull/2029#issuecomment-236952960) was rejected, because: > Please no tiff yet. This is still experimental, no...

I had a closer look, and despite that I have not been able to reproduce test failures (Windows, libtiff 4.6.0 and 4.7.0; `tiff_sizeproc()` is never called), I think you are...

Is that only an issue with current `master`? If so, possibly related to https://github.com/cmsimple-xh/cmsimple-xh/pull/660.

`XH_builtinTemplate()` prevents `XH_finalCleanUp()` from being called. See detailed analysis and possible fix at https://cmsimpleforum.com/viewtopic.php?f=16&t=21752&p=93035#p93053. PS: Note that this is a general CMSimple_XH issue, not specific to this plugin. Thus I'm...

Thank you for the PR! However, I'm not sure how to document this. Note that `null` is just a special case; a stringable object would also be accepted (https://3v4l.org/jFgDD). But...